• Peter Marshall's avatar
    [inspector] Throw during debug-eval when accessing function prototypes · 9691c5cf
    Peter Marshall authored
    Function prototypes can be lazily allocated. This means they go into the
    temporary objects set that debug-eval uses to figure out if a write
    will be side-effect free.
    
    We were incorrectly classifying writes to function prototypes as
    side-effect free because the prototype happened to be lazily allocated
    when we first accessed it during debug-eval, but was actually reachable
    from the function (not allocated temporarily).
    
    To do this we introduced a way to temporarily turn off the temporary
    object tracking, and we use it when lazily allocating function
    prototypes.
    
    This could mean that we incorrectly report side-effects when writing to
    function prototypes for functions which were themselves created during
    debug-eval side-effect free mode. However, it's unclear if this is a
    problem, because function declarations set global variables which would
    already throw due to side-effects.
    
    Bug: chromium:1154193
    Change-Id: I444a673662095f6deabaafdce3cdf3d86b71446d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2581968Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71692}
    9691c5cf
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...