• yangguo's avatar
    [debug] always add debug slot for statements. · 9611a4d2
    yangguo authored
    Previously we would elide debug slots if the statement position it
    belongs to has just already been written. The motivation is that since
    we should only break once per statement, we can elide debug slots that
    has the same statement position as the previous debug slot.
    
    This is an unnecessary optimization, since the debugger has yet another
    check against breaking twice at the same statement at runtime, in
    Debug::Break.
    
    This optimization can also be wrong, if there is control flow involved,
    for example if we can jump to the elided debug slot without executing
    the previous debug slot.
    
    CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
    R=jgruber@chromium.org
    
    Review-Url: https://codereview.chromium.org/2080173002
    Cr-Commit-Position: refs/heads/master@{#37107}
    9611a4d2
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...