• Andreas Haas's avatar
    [wasm] Cleanup calls to CalculateGlobalOffsets · 960c672c
    Andreas Haas authored
    CalculateGlobalOffsets has to be called once after all globals got
    defined but before global offsets get accessed, e.g. during code
    generation. It is not clear though when exactly CalculateGlobalOffsets
    should be called. The globals section may not exist, so at the end of
    the globals section is not enough (globals can also be defined in the
    import section). At the beginning of the code section is also not good
    enough, because the code section may not exist. At the end of the module
    may be too late.
    
    With this CL, CalculateGlobalOffsets is called after the global section,
    before the code section, and at the end of the module. Additionally the CL
    checks if CalculateGlobalOffsets has already been called, so that it is
    not executed a second time.
    
    R=manoskouk@chromium.org
    
    Bug: v8:11185
    Change-Id: I922b9f60a4a17a09d2527fd9ab35cda71226030c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2551100
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarManos Koukoutos <manoskouk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71314}
    960c672c
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...