• Adam Klein's avatar
    [parser] Skipping inner funcs: accurately record NeedsHomeObject · 94a71d7c
    Adam Klein authored
    Inner functions which called eval, and were the kind of functions
    that can use `super`, were erroneously not marked as "uses_super_property",
    leading to downstream crashes when the runtime tried to load the
    [[HomeObject]] from them.
    
    This patch eliminates the public Scope::uses_super_property()
    API and ensures that callers always call Scope::NeedsHomeObject()
    instead.
    
    This is a minimal fix designed for easy merging; it's likely that
    in the long run we should remove most mentions of "uses super property"
    and replace them with "needs home object" for clarity.
    
    Bug: v8:5516, chromium:774994
    Change-Id: Id269dd33e35bd40f6b59a3d3e19330687afa64f8
    Reviewed-on: https://chromium-review.googlesource.com/721879Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48619}
    94a71d7c
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...