• Clemens Backes's avatar
    [wasm] Avoid redundant recompilation · 945fabf5
    Clemens Backes authored
    In certain situations (especially if the profiler is disabled) it can
    happen that multiple isolates trigger tier-up at the same time. Each
    recompilation would then identify the set of functions to recompile and
    add compilation units for them. This creates lots of redundant
    compilation, which takes time and can exceed the total wasm code space
    limit (code would later get garbage-collected, but there is a high
    peak).
    This CL fixes that by always finishing a running recompilation before
    starting a new one. Since typically concurrent recompilations all
    recompile for the same tier, this would avoid do most compilation only
    once, and later recompilations can skip most functions.
    
    The only redundant compilation that can happen is via compilation units
    that are still executing while the next recompilation starts, but those
    should not create too much redundant code.
    
    R=thibaudm@chromium.org
    
    Bug: chromium:1114093
    Change-Id: If8fa7d953f3ce77a9d146458bf5e17bb9bf97219
    Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng
    Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2379851
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69588}
    945fabf5
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...