• Jakob Kummerow's avatar
    [test] Object verification should not recurse · ad8f2f6f
    Jakob Kummerow authored
    When running with --verify-heap, ObjectVerify() is invoked for every
    live object anyway, so there is no need for individual FooVerify()
    implementations to recursively request verification of their
    sub-objects. If they do, (a) it is duplicated work of O(n²) complexity,
    and (b) it can cause fuzzer-generated tests to crash because they run
    out of stack space when they trigger heap verification with very little
    stack space left.
    
    Fixed: chromium:1106426
    Change-Id: Ib9bd444806b148fffc23d635f931dfe73fe7e4ce
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358746
    Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69477}
    ad8f2f6f
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
basic-block-profiler.cc Loading commit data...
basic-block-profiler.h Loading commit data...
code-tracer.h Loading commit data...
compilation-statistics.cc Loading commit data...
compilation-statistics.h Loading commit data...
disasm.h Loading commit data...
disassembler.cc Loading commit data...
disassembler.h Loading commit data...
eh-frame.cc Loading commit data...
eh-frame.h Loading commit data...
gdb-jit.cc Loading commit data...
gdb-jit.h Loading commit data...
objects-debug.cc Loading commit data...
objects-printer.cc Loading commit data...
perf-jit.cc Loading commit data...
perf-jit.h Loading commit data...
unwinder.cc Loading commit data...
unwinding-info-win64.cc Loading commit data...
unwinding-info-win64.h Loading commit data...