• Dan Elphick's avatar
    [heap] Add SharedReadOnlySpace for shared RO_SPACE · 93cfa458
    Dan Elphick authored
    When RO_SPACE is to be shared, this constructs SharedReadOnlySpace
    object (via ReadOnlySpace::DetachPagesAndAddToArtifacts) that contains
    the shared artifacts and the original ReadOnlySpace is destroyed. This
    is mostly a conceptual change and SharedReadOnlySpace behaves
    identically to ReadOnlySpace (and subclasses it).
    
    Also adds ReadOnlyArtifacts that contains the shared artifacts and which
    is stored as a std::weak_ptr in a global so it can be destroyed when all
    std::shared_ptrs to it are destroyed. Since this allows the ReadOnlyHeap
    to be reconstructed when all Isolates are destroyed,
    ReadOnlyHeap::ClearSharedHeapForTest is removed along with all uses
    since that is now done automatically.
    
    The ReadOnlyArtifacts class now owns all the shared artifacts and is
    responsible for deleting them on exit (mostly via unique_ptr).
    
    Bug: v8:10454
    Change-Id: I2fe7110a4ab9cf8719dd198bafc1d083bee641b1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154204
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67440}
    93cfa458
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...