• Clemens Backes's avatar
    [wasm] Refactor and fix wasm serialization test · 9349fb78
    Clemens Backes authored
    This fixes a few issues:
    1) It avoids using the {DeserializeOrCompile} API method, which is not
       used in chrome any more and will be deprecated soon.
    2) It switches to the {DeserializeNativeModule} internal method, which
       really checks deserialization in isolation and does not fall back to
       compiling the wire bytes if the serialized bytes are incorrect.
    3) It disables a test which tried to invalidate the number of functions,
       but the respective bytes were already zero, so nothing was
       invalidated. This still needs to be fixed in a follow-up CL.
    4) It serializes the modules in a separate isolate, which then gets
       disposed to free references to the NativeModule and remove it from
       the modules cache. Otherwise we will just never deserialize, but use
       the cached module instead.
    
    R=thibaudm@chromium.org
    
    Bug: v8:6847, v8:10146
    Change-Id: I37ef524a9c96c32fec2e7466488d67395fa5ccea
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2010786
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65888}
    9349fb78
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...