• Clemens Backes's avatar
    [wasm] Replace RecursiveMutex by Mutex · eb7a36be
    Clemens Backes authored
    Some of the methods in {WasmCodeAllocator} can be called either without
    holding the lock, or while already holding it. In order to support both
    situations, we used a {RecursiveMutex} so far.
    This CL refactors this to be a simple {Mutex} again, and passes a
    {WasmCodeAllocator::OptionalLock} object which stores whether the lock
    is already held or not.
    Note that getting the lock twice fails immediately in debug builds,
    while forgetting to get the lock might only fail on TSan.
    
    The alternative would be to duplicate all methods, having one variant
    that expects that the lock is held and one that assume that it's
    unlocked. It would be multiple methods though to duplicate across both
    {NativeModule} and {WasmCodeAllocator}, hence I went for the
    {OptionalLock} instead.
    
    Bug: v8:9477
    
    R=mstarzinger@chromium.org
    
    Change-Id: I4e32286cdb93385ac655d408191b330efdd7ad66
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1825338
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64137}
    eb7a36be
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...