• lpy's avatar
    [Tracing] Fix inaccurate timer calculation in runtime statistics. · 92d9a56a
    lpy authored
    Previously we reset runtime counters and dump them when we enter, exit top level
    trace events respectively. However, there is gap between two top level trace
    events and runtime counters may be activated, resetting the counters makes the
    accumulated time inaccurate, and we may end up with negative time due to the
    nature of how we accumulate time.
    
    This patch fixes this problem by only resetting counters when there's no
    counters active, and before dump counters, we traverse current active counters
    to calculate their time, and then restart their timer.
    
    BUG=chromium:658145
    
    Review-Url: https://codereview.chromium.org/2457523002
    Cr-Commit-Position: refs/heads/master@{#40653}
    92d9a56a
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...