• Benedikt Meurer's avatar
    [interpreter] Do ToObject implicitly as part of CloneObject. · 92c6af8a
    Benedikt Meurer authored
    The CloneObject bytecode was only able to handle objects, null and
    undefined, and explicit bytecode had to be generated to perform the
    ToObject outside the bytecode (unlike the other IC bytecodes that
    just perform the ToObject implicitly). That means the simplest possible
    object cloning would also generate a sequence of 5 bytecodes (at least):
    
    ```
       Mov <register>, a0
       JumpIfNull @1
       JumpIfUndefined @1
       ToObject <register>
    1: CloneObject <register>
    ```
    
    That is quite wasteful and unnecessary, since the core logic in the
    runtime already does the ToObject properly anyways. This change
    refactors the CloneObjectIC slightly to behave more like the other ICs
    and do the ToObject implicitly when necessary.
    
    Bug: v8:7611, v8:9114, v8:9183, v8:9343
    Change-Id: I11973e90bf875f154a5a7739287bee17041e4a7a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649554Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62064}
    92c6af8a
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...