• Dominik Inführ's avatar
    [heap] Attach to shared isolate after setting up main thread · 929b83fb
    Dominik Inführ authored
    Attach to the shared isolate after the main thread was set up. Otherwise
    it could happen that a shared GC initiated from another isolate might
    see no threads are running and performs the safepoint operation in the
    middle of isolate deserialization.
    
    We use DisallowSafepoints to check that the isolate doesn't join a
    global safepoint before deserialization is complete. DisallowSafepoints
    used to prevent only invocations of Safepoint() but was updated to
    also prevent Park() and Unpark() invocations. Each state change could
    cause the thread to reach a safepoint, which would allow a shared GC
    to run.
    
    We now also DCHECK that every isolate has at least one local heap and
    that shared collections aren't started before deserialization is
    complete.
    
    Bug: v8:11708
    Change-Id: Iba3fb59dd951d5ee4fc9934158062287302fc279
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3221157
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77424}
    929b83fb
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...