• rossberg@chromium.org's avatar
    Retry landing "Implement zone-allocated types" · 928d71f8
    rossberg@chromium.org authored
    Works around apparent scoping bug in VS, the only change to before being a method rename in the test suite:
    
    --- a/test/cctest/test-types.cc
    +++ b/test/cctest/test-types.cc
    @@ -153,7 +153,7 @@ struct ZoneRep {
         return reinterpret_cast<ZoneList<ZoneType*>*>(AsTagged(t));
       }
    
    -  static Zone* Region(Zone* zone, Isolate* isolate) { return zone; }
    +  static Zone* ToRegion(Zone* zone, Isolate* isolate) { return zone; }
     };
    
    @@ -168,7 +168,7 @@ struct HeapRep {
       static Object* AsConstant(Handle<Type> t) { return Box::cast(*t)->value(); }
       static FixedArray* AsUnion(Handle<Type> t) { return FixedArray::cast(*t); }
    
    -  static Isolate* Region(Zone* zone, Isolate* isolate) { return isolate; }
    +  static Isolate* ToRegion(Zone* zone, Isolate* isolate) { return isolate; }
     };
    
    @@ -183,7 +183,7 @@ struct Tests : Rep {
           isolate(CcTest::i_isolate()),
           scope(isolate),
           zone(isolate),
    -      T(Rep::Region(&zone, isolate), isolate) {
    +      T(Rep::ToRegion(&zone, isolate), isolate) {
       }
    
       static void CheckEqual(TypeHandle type1, TypeHandle type2) {
    
    R=titzer@chromium.org
    BUG=
    
    Review URL: https://codereview.chromium.org/143693003
    
    git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18711 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
    928d71f8
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...