• Ben Smith's avatar
    Reland "[wasm] Implement table.init for interpreter" · 9010424f
    Ben Smith authored
    This is a reland of 63608968
    
    The previous CL failed on Windows, but it was a general bug. The
    dropped_elem_segments was not being set on the instance properly in
    cctests, so`table.init` instructions would fail by reading uninitialized
    data.
    
    I took this opportunity to also add an implementation of
    `elem.drop` in the interpreter, and ported the JS tests for those too.
    
    Original change's description:
    > [wasm] Implement table.init for interpreter
    >
    > This also fixes CheckCallViaJS when a trap occurs. In that case, the
    > trap callback is called instead of an exception being thrown, so if it
    > isn't handled, a bogus result will be returned instead.
    >
    > Bug: v8:8965
    > Change-Id: I560e89f353756df23c062fb8c9484d9971c19253
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539078
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Commit-Queue: Ben Smith <binji@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#60473}
    
    Bug: v8:8965
    Change-Id: Ia547d9530b7ca67fde5bd94539f49153b796e82d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547142
    Commit-Queue: Ben Smith <binji@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60664}
    9010424f
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...