• Andreas Haas's avatar
    [wasm] Type check brtable if it's not unreachable · 8ff14f5b
    Andreas Haas authored
    There was a bug in the function body decoder where
    type checking of brtable only happened if the brtable
    instruction is reachable. However, type checking is
    required in all cases where brtable "not unreachable".
    The difference between reachable and "not unreachable"
    is a state called spec-reachable where a clever
    compiler can already infer that the code will be
    unreachable (e.g. a memory access is out of bounds
    just by the offset and therefore unconditionally
    traps), but the spec can not. If an instruction is
    only spec-reachable, it still has to be type checked.
    
    R=clemensb@chromium.org
    FIX=chromium:1046472
    
    Change-Id: I7e9f1108597871615c0d443a0e94de35a0207b5e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2027990
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66049}
    8ff14f5b
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...