• Clemens Backes's avatar
    [wasm] Fix OSR on wasm calls · 851a395f
    Clemens Backes authored
    This fixes issues with replacing the return address of deeper (non-top)
    wasm frames, i.e. frames which are at a call position. The replaced
    address should also point after the call in the new code, so we don't
    execute the same call again.
    
    This is achieved by using slightly different encodings for breakpoint
    positions and other (wasm instruction) positions. Breakpoints set
    {is_instruction} to {false} in the source position table entry, whereas
    usual wasm instruction set it to {true}.
    Also, during stack walking for OSR, we remember whether we want to OSR
    to the position before the instruction (if it's the top frame), or after
    the call instruction (if it's deeper in the stack). We then use the
    {is_instruction} predicate to find the right location.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10321
    Change-Id: I73212a7532c6ecf4c82bde76fe4059c8203e422c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116206Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66850}
    851a395f
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...