• mvstanton's avatar
    Revert of Type Feedback Vector lives in the closure (patchset #12 id:260001 of... · e2e7dc32
    mvstanton authored
    Revert of Type Feedback Vector lives in the closure (patchset #12 id:260001 of https://codereview.chromium.org/1563213002/ )
    
    Reason for revert:
    FAilure on win32 bot, need to investigate webkit failures.
    
    Original issue's description:
    > Type Feedback Vector lives in the closure
    >
    > We get less "pollution" of type feedback if we have one vector per native
    > context, rather than one for the whole system. This CL moves the vector
    > appropriately.
    >
    > We rely more heavily on the Optimized Code Map in the SharedFunctionInfo. The
    > vector actually lives in the first slot of the literals array (indeed there is
    > great commonality between those arrays, they can be thought of as the same
    > thing). So we make greater effort to ensure there is a valid literals array
    > after compilation.
    >
    > This meant, for performance reasons, that we needed to extend
    > FastNewClosureStub to support creating closures with literals. And ultimately,
    > it drove us to move the optimized code map lookup out of FastNewClosureStub
    > and into the compile lazy builtin.
    >
    > The heap change is trivial so I TBR Hannes for it...
    >
    > TBR=hpayer@chromium.org
    >
    > BUG=
    >
    > Committed: https://crrev.com/a5200f7ed4d11c6b882fa667da7a1864226544b4
    > Cr-Commit-Position: refs/heads/master@{#33518}
    
    TBR=bmeurer@chromium.org,akos.palfi@imgtec.com
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=
    
    Review URL: https://codereview.chromium.org/1632993003
    
    Cr-Commit-Position: refs/heads/master@{#33520}
    e2e7dc32
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
x64 Loading commit data...
x87 Loading commit data...
OWNERS Loading commit data...
full-codegen.cc Loading commit data...
full-codegen.h Loading commit data...