• Clemens Hammacher's avatar
    [wasm] Skip deadlocking tests on predictable platform · 8ede52ba
    Clemens Hammacher authored
    The predictable platform can make tasks deadlock if the spawning task
    is holding a lock that the spawn task also wants to take. This is
    because the spawned task is just executed immediately within the
    "context" of the spawning task.
    
    The wasm async compile tests deadlock because the
    {BackgroundCompileTask}s hold the shared {BackgroundCompileToken}
    (reader lock) while spawning new tasks via {OnBackgroundTaskStopped} ->
    {RestartBackgroundTasks}. The new tasks might want to cancel
    compilation via {BackgroundCompileToken::Cancel}, which takes the
    writer lock and hence deadlocks.
    This can not happen on any other platform, since tasks are not nested
    that way.
    
    R=ahaas@chromium.org
    
    Bug: v8:9760
    No-Try: true
    Change-Id: I9fc34d5de386aa5c6fdd64a1570fddcff872ec95
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1816502Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63904}
    8ede52ba
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...