• Leszek Swirski's avatar
    [offthread] Pin OffThreadIsolate to a given thread · 8e8d61b3
    Leszek Swirski authored
    Previously OffThreadIsolates set their thread-id on construction. This
    thread-id could later be used in DCHECKs, comparing it against the
    current thread's id.
    
    However, OffThreadIsolates are created on the main thread (as they need
    access to the Isolate and especially Heap for initialization). So, the
    thread-id was actually not the background thread's id.
    
    Now, OffThreadIsolate has a PinToCurrentThread method which should be
    called on whichever thread wants to actually use it. This pinning can
    only be done once, and the OffThreadIsolate is considered invalid before
    this method is called.
    
    Bug: chromium:1011762
    Change-Id: Ie9d7838152683aea2a326a4e5d1dbd59a747131f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2110016
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66864}
    8e8d61b3
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...