• Tom Tan's avatar
    Avoid defining class name `Label` as type alias in cctest because it is used by V8 · 8d107684
    Tom Tan authored
    It is not recommended to define type alias in C++ header file. cctest defines
    type alias `using Label=CodeAssemblerLabel` in anonymous namespace under
    namespace `v8::internal::compiler` in test-code-assembler.cc. This is fine
    because this type alias is expected to take effect only in this .cc file. But in
    jumbo build, multiple source files are combined as a single one, and the
    previous `Label` type alias could shadow definition of `Label` from other header
    file (for example, v8/src/codegen/label.h which is included by another .cc file)
    This is totally unexpected and triggers bad class layout and accessing in the
    latter .cc file for the places where `Label` is referenced.
    
    This change fixes cctest from Windows ARM64 jumbo build, but it applies to
    other architectures too.
    
    Bug: chromium:893460
    Change-Id: Ib2e9df76f6e3371b3940649668c5d13e6b36f028
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1788537Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#63605}
    8d107684
Name
Last commit
Last update
..
c-signature.h Loading commit data...
call-tester.h Loading commit data...
code-assembler-tester.h Loading commit data...
codegen-tester.cc Loading commit data...
codegen-tester.h Loading commit data...
function-tester.cc Loading commit data...
function-tester.h Loading commit data...
graph-and-builders.h Loading commit data...
serializer-tester.cc Loading commit data...
serializer-tester.h Loading commit data...
test-basic-block-profiler.cc Loading commit data...
test-branch-combine.cc Loading commit data...
test-code-assembler.cc Loading commit data...
test-code-generator.cc Loading commit data...
test-gap-resolver.cc Loading commit data...
test-graph-visualizer.cc Loading commit data...
test-instruction-scheduler.cc Loading commit data...
test-instruction.cc Loading commit data...
test-js-constant-cache.cc Loading commit data...
test-js-context-specialization.cc Loading commit data...
test-js-typed-lowering.cc Loading commit data...
test-jump-threading.cc Loading commit data...
test-linkage.cc Loading commit data...
test-loop-analysis.cc Loading commit data...
test-machine-operator-reducer.cc Loading commit data...
test-multiple-return.cc Loading commit data...
test-node.cc Loading commit data...
test-operator.cc Loading commit data...
test-representation-change.cc Loading commit data...
test-run-bytecode-graph-builder.cc Loading commit data...
test-run-calls-to-external-references.cc Loading commit data...
test-run-deopt.cc Loading commit data...
test-run-intrinsics.cc Loading commit data...
test-run-jsbranches.cc Loading commit data...
test-run-jscalls.cc Loading commit data...
test-run-jsexceptions.cc Loading commit data...
test-run-jsobjects.cc Loading commit data...
test-run-jsops.cc Loading commit data...
test-run-load-store.cc Loading commit data...
test-run-machops.cc Loading commit data...
test-run-native-calls.cc Loading commit data...
test-run-retpoline.cc Loading commit data...
test-run-stackcheck.cc Loading commit data...
test-run-tail-calls.cc Loading commit data...
test-run-unwinding-info.cc Loading commit data...
test-run-variables.cc Loading commit data...
value-helper.cc Loading commit data...
value-helper.h Loading commit data...