• Tom Tan's avatar
    Avoid defining class name `Label` as type alias in cctest because it is used by V8 · 8d107684
    Tom Tan authored
    It is not recommended to define type alias in C++ header file. cctest defines
    type alias `using Label=CodeAssemblerLabel` in anonymous namespace under
    namespace `v8::internal::compiler` in test-code-assembler.cc. This is fine
    because this type alias is expected to take effect only in this .cc file. But in
    jumbo build, multiple source files are combined as a single one, and the
    previous `Label` type alias could shadow definition of `Label` from other header
    file (for example, v8/src/codegen/label.h which is included by another .cc file)
    This is totally unexpected and triggers bad class layout and accessing in the
    latter .cc file for the places where `Label` is referenced.
    
    This change fixes cctest from Windows ARM64 jumbo build, but it applies to
    other architectures too.
    
    Bug: chromium:893460
    Change-Id: Ib2e9df76f6e3371b3940649668c5d13e6b36f028
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1788537Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#63605}
    8d107684
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...