• Georg Neis's avatar
    [turbofan] Fix CHECK failure in graph verifier · 8c0b68e3
    Georg Neis authored
    ForInNext can get lowered to a low-level call to the ForInFilter
    builtin. We currently type low-level Call nodes simply as Any, leading
    to a CHECK failure when the verifier expects a primitive.
    
    This CL fixes the issue simply by manually setting the type as part of
    the lowering. An alternative would be to have the Call typing inspect
    its input similar to what the JSCall typing does. We can consider this
    if we hit the same issue in other cases.
    
    Bug: chromium:1102053
    Change-Id: I6682d8cf95c6a3ebaff9c8de677aa20ca676573f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282523Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68688}
    8c0b68e3
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...