• ssanfilippo's avatar
    [Interpreter] Handle negative ints in generate-bytecode-expectations. · 8bfd4a5a
    ssanfilippo authored
    The previous implementation used GetRawOperand(), which allows a nicely
    unified handling of all scalar types, but returns an unsigned type.
    Because of this, generate-bytecode-expectations couldn't properly handle
    negative numbers.
    
    This commit differentiate between different types of scalar operands and
    uses the appropriate getter from i::interpreter::BytecodeArrayIterator,
    thus correctly handling signed types where needed.
    
    Two new helpers have been added to i::interpreter::Bytecodes:
    
     * IsImmediateOperandType()
     * IsIndexOperandType()
    
    with the intuitive semantic.
    
    BUG=v8:4280
    LOG=N
    
    Review URL: https://codereview.chromium.org/1684113002
    
    Cr-Commit-Position: refs/heads/master@{#33874}
    8bfd4a5a
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...