• Camillo Bruni's avatar
    Revert "[test][d8] Add d8.log.getAndStop helper" · 8bf237dd
    Camillo Bruni authored
    This reverts commit 95aa697b.
    
    Reason for revert: breaks under tsan
    
    Original change's description:
    > [test][d8] Add d8.log.getAndStop helper
    > 
    > The new helper function allows us to write tests for log parsing
    > without the need to first generating a log file. This makes it easier
    > to spot errors when the log format changes.
    > 
    > - Add d8 global variable
    > - Add file_name accessor to Logger and Log classes
    > - Change OS::LogFileOpenMode to w+ / wb+
    > - Use separate Log::WriteLogHeader method
    > - Remove unused logger_ instance variable from Log
    > 
    > Bug: v8:10644
    > Change-Id: Ifc7e35aa4e91b3f01f0847843263946e085944c3
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2387563
    > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#69715}
    
    TBR=mlippautz@chromium.org,cbruni@chromium.org,gsathya@chromium.org,verwaest@chromium.org
    
    Change-Id: Iad47d2f1e3391cae3c2f8c9e6c904c43925e1671
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:10644
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2396080Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69717}
    8bf237dd
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...