• Omer Katz's avatar
    cppgc: Fix crash when finalizing incremental GC. · 8ba4bcea
    Omer Katz authored
    The gc_in_progress flag was reset to false only after sweeping was done.
    As a result, if we call CollectGarbage during an incremental GC and
    after marking has finished, the we will observe that a gc is still in
    progress but will not have a marker and crash.
    
    The immediate solution is to move resetting the gc_in_progress flag such
    that it indicates whether we didn't have the atomic pause yet. That
    means we could have gc_in_progress==false and incremental sweeping still
    running, which semantically negates the meaning of gc_in_progress.
    
    Observing that gc_in_progress essentially becomes equivalent to having a
    marker, this CL removes the gc_in_progress flag and replaces checks on
    it with checks on marker.
    
    Bug: chromium:1156170
    Change-Id: Ic4b441ec248b5f7e222e988870e46d5166dd4dcc
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584875
    Commit-Queue: Omer Katz <omerkatz@chromium.org>
    Auto-Submit: Omer Katz <omerkatz@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71712}
    8ba4bcea
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...