• Daniel Clark's avatar
    [modules][api] Implement HostGetSupportedImportAssertions · 8ae4dc40
    Daniel Clark authored
    Implement the HostGetSupportedImportAssertions, whose purpose
    is to filter the list of import assertions exposed to the embedder to
    only those assertion with keys that the embedder recognizes. See
    https://tc39.es/proposal-import-assertions/#sec-hostgetsupportedimportassertions.
    
    This change doesn't actually implement it as a callback, but instead
    passes the supported assertions during creation of the Isolate via
    CreateParams. This expresses clearly the requirement that the supported
    assertions must never change for the lifetime of the Isolate.
    
    Note that we still need to maintain all assertions in a map
    while parsing the import assertions clause, because duplicate keys for
    an unsupported assertion still needs to be detected as a parse error. So,
    the filtering is done later during
    SourceTextModuleDescriptor::AstModuleRequest::Serialize.
    
    The actual filtering algorithm simply iterates the assertions and the
    supported assertion keys in a nested loop. There's currently only one
    assertion in use ("type"), so there should be no reason to get too
    clever here unless at least several more assertions are generally
    supported.
    
    Bug: v8:10958
    Change-Id: I9a2d965e9d452718d0ddfe9dca55b7b4ed963019
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2572173Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Commit-Queue: Dan Clark <daniec@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#71776}
    8ae4dc40
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...