• Tobias Tebbi's avatar
    Reland "cppgc: Add DCHECK that object start bitmap is safe to use" · 89c213bb
    Tobias Tebbi authored
    This reverts commit ad09811a.
    
    Reason for revert: reverted by accident
    
    Original change's description:
    > Revert "cppgc: Add DCHECK that object start bitmap is safe to use"
    >
    > This reverts commit 9e1db518.
    >
    > Reason for revert: https://chromium-review.googlesource.com/c/v8/v8/+/3535782 causes roll failures, this needs to be reverted too because it's based on it
    >
    > Original change's description:
    > > cppgc: Add DCHECK that object start bitmap is safe to use
    > >
    > > During sweeeping/compaction the bitmap is being reconstructed and
    > > should not be relied on for finding object start.
    > > Add a DCHECK that the bitmap is fully populated.
    > >
    > > Bug: chromium:1307471
    > > Change-Id: I4aa414722262bb6fb169123a49fce1510a60d3ef
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3540680
    > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > > Commit-Queue: Omer Katz <omerkatz@chromium.org>
    > > Cr-Commit-Position: refs/heads/main@{#79575}
    >
    > Bug: chromium:1307471
    > Change-Id: I377b8737609fff33199776dce3d997f31074c59b
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545316
    > Auto-Submit: Tobias Tebbi <tebbi@google.com>
    > Owners-Override: Tobias Tebbi <tebbi@google.com>
    > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    > Cr-Commit-Position: refs/heads/main@{#79586}
    
    Bug: chromium:1307471
    Change-Id: I04357072c6974e045c1e2bdea93d4059a1e987b2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545319
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Owners-Override: Tobias Tebbi <tebbi@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79592}
    89c213bb
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...