• Seth Brenith's avatar
    Allow no-op background merges to complete · 890ee74c
    Seth Brenith authored
    It is possible, though unlikely, that V8 will deserialize code cache
    data, decide to merge that new data with an existing script from the
    Isolate compilation cache, and subsequently do nothing in the background
    portion of the merge (make no heap changes, and request no follow-up
    changes on the main thread). In this case, the most optimal outcome is
    to reuse the script from the Isolate compilation cache, not to use the
    newly deserialized script.
    
    CodeSerializer::FinishOffThreadDeserialize uses
    BackgroundMergeTask::HasPendingForegroundWork to determine whether it
    should complete the merge and use the Script from the compilation cache
    or complete the deserialization and use the newly deserialized Script.
    This change updates HasPendingForegroundWork so that it will return true
    even if the merge was a no-op.
    
    Bug: v8:12808
    Change-Id: I08fcb814e797218e5be2b4ce4f45bd4e0637ec80
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3916270
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83439}
    890ee74c
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...