• Seth Brenith's avatar
    [torque] Verify nested struct fields in classes · 88a2d011
    Seth Brenith authored
    As one of several steps involved in supporting struct-valued fields
    within classes, this CL generates type verification code for the data
    contained in those structs.
    
    In order to generate verification code, Torque needs to know about
    struct field offsets and the total size of structs. Those calculations
    are added to StructType itself and the function TypeVisitor::ComputeType
    which initializes the StructType. I repurposed the Field::offset value
    to behave in structs more like it does in classes (it had previously
    indicated the index of a field within a struct, but nobody used that
    value). Overall this works okay, and I think it's less confusing to have
    Field::offset mean the same thing everywhere. However, some struct
    fields have types with unknown size (Field::GetFieldSizeInformation
    fails), so those fields are now marked with offset Field::kInvalidOffset
    to indicate that the structs containing them should not be used within
    class fields or anywhere else that requires packed layout.
    
    Bug: v8:7793
    Change-Id: If2677c8c81efc85e63b4bfb831d818a748427e18
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1897247
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65016}
    88a2d011
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...