• Jakob Gruber's avatar
    Include standard heap object header when debug-printing String objects · 86fee30e
    Jakob Gruber authored
    This brings %DebugPrint(string) closer to %DebugPrint(object) by also
    including the pointer, object kind, and RO/old space. Especially the
    pointer can be useful while debugging.
    
    One could consider going even further end printing full details of
    the string object, e.g. first and second pointers for cons strings.
    
    Before:
    
     $ out/debug/d8 --allow-natives-syntax -e '%DebugPrint("abc");'
     DebugPrint: #abc
     0x263f080402cd: [Map] in ReadOnlySpace
     [...]
    
    After:
    
     $ out/debug/d8 --allow-natives-syntax -e '%DebugPrint("abc");'
     DebugPrint: 0xa830824ffe1: [String] in OldSpace: #abc
     0xa83080402cd: [Map] in ReadOnlySpace
     [...]
    
    Drive-by: Document string printing functions.
    Drive-by: Use PrintUC16 in spots that don't want a full debug print.
    
    Bug: v8:10581
    Change-Id: Ided59047b9c3edc1830ce7721376dddfd24fad1d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228509Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68136}
    86fee30e
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...