• Clemens Hammacher's avatar
    [wasm] Fix flaky OOM on memory allocation · 863e6ce9
    Clemens Hammacher authored
    We still see occasions of "WebAssembly Instantiation: Out of memory:
    wasm memory", e.g. on the N5X arm64 bot.
    
    We already have a retry-loop around the {ReserveAddressSpace} call, so
    this error can only happen if {AllocatePages} fails.
    I cannot easily reproduce, so I will land this CL and hope that it
    fixes the flake.
    
    We might eventually replace all these gc-then-retry loops by a better
    mechanism which knows about process-wide allocations. Currently,
    {AllocatePages} is isolate-independent, and only calls
    {Platform::OnCriticalMemoryPressure}, but this call does nothing on the
    default platform. So trigger a GC on the current isolate instead.
    
    R=mlippautz@chromium.org
    
    Bug: chromium:883639, v8:7872, v8:8158
    Change-Id: Ib4e4a4a5f6b598d5832c327b1fc83ccb3bada9bc
    Reviewed-on: https://chromium-review.googlesource.com/1226886Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55955}
    863e6ce9
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...