• Benedikt Meurer's avatar
    [inspector][wasm] Unify locals, stack, and globals objects. · 85fdbd91
    Benedikt Meurer authored
    This change unifies the locals, stack, and globals objects exposed for
    WebAssembly frames via the Scope view and via DebugEvaluate to use the
    same underlying objects (implemented via interceptors). This also
    means that for locals and globals we now consistently expose names
    prefixed by a dollar symbol everywhere.
    
    Drive-by-fix: Move the debug::ScopeIterator implementation for WasmFrame
    into debug-wasm-support.cc, so WebAssembly scope details are all found
    in one place instead of scattered around the code.
    
    Drive-by-cleanup: Rename GetJSDebugProxy to GetWasmDebugProxy for
    consistency. GetJSDebugProxy is a bit misleading, since the debug proxy
    is not about JavaScript, but just exposed to JavaScript.
    
    Doc: http://bit.ly/devtools-wasm-entities
    Bug: chromium:1159307, chromium:1127914, chromium:1162229
    Change-Id: If932bd06bbce72542823f63dac1bd976ab33937a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2615348
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72009}
    85fdbd91
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...