• Mythri A's avatar
    Evict deoptimized code on feedback vector after creating the closure · 85b1d24b
    Mythri A authored
    When creating a new closure, we check feedback vector for any optimized
    code and install it on the newly created closure. We evict the optimized
    code from the feedback vector if it is marked for deoptimization. We
    used to evict the code before creating the new closure. However,
    creating a new closure could cause allocation failures and hence trigger
    a GC. This could mark optimized code on feedback vector for
    deoptimization if any weak objects held by optimized code are GC'ed.
    
    This cl delays the eviction unitl after the closure was created.
    
    Bug: v8:1163184
    Change-Id: I217279e4a51f75b87bb7ae5a00fd1cf57805e3c8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2613034
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71999}
    85b1d24b
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...