• Clemens Backes's avatar
    [wasm] Fix OSR on wasm calls · 851a395f
    Clemens Backes authored
    This fixes issues with replacing the return address of deeper (non-top)
    wasm frames, i.e. frames which are at a call position. The replaced
    address should also point after the call in the new code, so we don't
    execute the same call again.
    
    This is achieved by using slightly different encodings for breakpoint
    positions and other (wasm instruction) positions. Breakpoints set
    {is_instruction} to {false} in the source position table entry, whereas
    usual wasm instruction set it to {true}.
    Also, during stack walking for OSR, we remember whether we want to OSR
    to the position before the instruction (if it's the top frame), or after
    the call instruction (if it's deeper in the stack). We then use the
    {is_instruction} predicate to find the right location.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10321
    Change-Id: I73212a7532c6ecf4c82bde76fe4059c8203e422c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116206Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66850}
    851a395f
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...