• Leszek Swirski's avatar
    [turbofan] Avoid megamorphic loads for zero-map mono/polymorphic sites · 8428feed
    Leszek Swirski authored
    Soft-deopt for mono/polymorphic property accesses that don't have any
    maps, and only allow zero-map feedback to be monomorphic. This makes
    sure we only emit a megamorphic LoadIC builtin call if the IC was
    actually megamorphic.
    
    JSGenericLowering assumed that zero maps meant that a load site is
    megamorphic. However, it can be the case that the call-site is
    monomorphic or polymorphic, and the maps had died. In this case we don't
    want to call the megamorphic IC builtin, as on a stub cache miss we
    fallback to a normal LoadIC miss, which can record mono/polymorphic
    feedback in the IC. After this, we'll enter a miss loop in the
    megamorphic load builtin, and worse the LoadIC assumes that there's
    something "wrong" with the feedback, so it'll keep trying to reconfigure
    the handler (possibly allocating new load handlers if this is a
    prototype field access).
    
    As a drive-by, rewrite GetRelevantReceiverMaps to be an in-place
    filtering of the maps rather than copying them.
    
    Change-Id: I0c25bfa606367fa81c43223bbd56cdadb5e789ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2150586Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67152}
    8428feed
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...