• Leszek Swirski's avatar
    [turbofan] Avoid megamorphic loads for zero-map mono/polymorphic sites · 8428feed
    Leszek Swirski authored
    Soft-deopt for mono/polymorphic property accesses that don't have any
    maps, and only allow zero-map feedback to be monomorphic. This makes
    sure we only emit a megamorphic LoadIC builtin call if the IC was
    actually megamorphic.
    
    JSGenericLowering assumed that zero maps meant that a load site is
    megamorphic. However, it can be the case that the call-site is
    monomorphic or polymorphic, and the maps had died. In this case we don't
    want to call the megamorphic IC builtin, as on a stub cache miss we
    fallback to a normal LoadIC miss, which can record mono/polymorphic
    feedback in the IC. After this, we'll enter a miss loop in the
    megamorphic load builtin, and worse the LoadIC assumes that there's
    something "wrong" with the feedback, so it'll keep trying to reconfigure
    the handler (possibly allocating new load handlers if this is a
    prototype field access).
    
    As a drive-by, rewrite GetRelevantReceiverMaps to be an in-place
    filtering of the maps rather than copying them.
    
    Change-Id: I0c25bfa606367fa81c43223bbd56cdadb5e789ef
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2150586Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67152}
    8428feed
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...