• adamk's avatar
    Sloppy eval declarations should not shadow lexical function declarations · 83b63c30
    adamk authored
    This was being allowed due to the use of BindingFlags instead of VariableMode
    to determine whether a looked-up binding was lexical. Because function
    declarations are hoisted, they never need hole checks, and so were being
    miscategorized as non-lexical.
    
    This patch augments Context::Lookup with a VariableMode out param, which
    allows this check to determine precisely whether the binding is lexical.
    
    BUG=v8:4454, v8:5256
    
    Review-Url: https://codereview.chromium.org/2206483004
    Cr-Commit-Position: refs/heads/master@{#38260}
    83b63c30
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...