• neis's avatar
    [tests] Fix bogus uses of assertThrows. · 837900ef
    neis authored
    Some tests passed a string as second argument to assertThrows, expecting it to
    be matched against the exception.  However, assertThrows simply ignored these.
    (Some other tests actually seem to use that argument as a comment ...)
    
    This CL
    - changes assertThrows to fail if the second argument is not a function,
    - adds assertThrowsEquals which compares the exception to a given value using
      assertEquals
    - fixes some bogus tests that got exposed by this.
    
    R=jarin@chromium.org
    BUG=
    
    Review URL: https://codereview.chromium.org/1544793002
    
    Cr-Commit-Position: refs/heads/master@{#33159}
    837900ef
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...