• Andreas Haas's avatar
    [wasm] Add instance to DebugBreak safepoint · 835a8b7d
    Andreas Haas authored
    Since recently, the WebAssembly instance gets cached in Liftoff code
    to avoid reloading it from the stack whenever it is used. Typically the
    cached instance gets invalidated at a function call and therefore does
    not need to be recorded in safepoints.
    
    However, when the DebugBreak builtin is called, the cached instance
    was not invalidated. It is even incorrect to invalidate the cached
    instance there because that would modify the CacheState of Liftoff.
    Therefore this CL adds the register that caches the instance to the
    safepoint of the call to the DebugBreak builtin.
    
    R=clemensb@chromium.org
    
    Bug: v8:11979
    Change-Id: I7f9153e0c0e7e797b11b827111b4d61e29606071
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3063222
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76021}
    835a8b7d
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...