• Jungshik Shin's avatar
    Intl.DateTimeFormat: throw RangeError for non-finite input · 831bc233
    Jungshik Shin authored
    intl.js throws an exception when datetime-value to format is
    Infinity or NaN, but there was a way to thwart the check.
    
    Moreover, intl.js and runtime-intl.cc have unnecessary conversions
    of 'Number->Date->Number'. I removed the unnecessary conversion
    and made 'Number' be passed to %InternalDateFormat.  With this
    streamlining, the work-around mentioned above does not work
    anymore.
    
    Add a check in runtime_intl.cc for Infinity/NaN and throw a
    RangeError.
    
    Add invalid-time test for invalid datetime-values passed to
    Intl.DateTimeFormat.format().
    
    Bug: chromium:774833
    Test: intl/date-format/invalid-time.js
    Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng
    Change-Id: Idc575e532a86ee110dc4bb945ae023d6516650ee
    Reviewed-on: https://chromium-review.googlesource.com/724860
    Commit-Queue: Jungshik Shin <jshin@chromium.org>
    Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48765}
    831bc233
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...