• Peter Marshall's avatar
    [cpu-profiler] Refactor ProfileGenerator · 82efa4bd
    Peter Marshall authored
    Rename it to Symbolizer because it does exactly that.
    
    Change the SymbolizeTickSample method to return the symbolized state
    rather than pass it on to the ProfilesCollection. This makes it easier
    to test as now it only relies on the CodeMap provided to it.
    
    Make EntryForVMState a free-floating function as it doesn't rely on
    state and then we can avoid importing the StateTag definition in the
    header.
    
    Remove the UNREACHABLE from EntryForVMState as the compiler got smarter
    and doesn't need it anymore.
    
    Pass the CpuProfilesCollection to SamplingEventsProcessor instead,
    as it is now responsible for putting the symbolized samples into the
    collection to be sorted into the appropriate profiles.
    
    Change-Id: I104290eff22b7d94a1bd34ba904036badccf4e13
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2440522
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70248}
    82efa4bd
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...