• bakkot's avatar
    Reland of Add errors for declarations which conflict with catch parameters.... · 819fe046
    bakkot authored
    Reland of Add errors for declarations which conflict with catch parameters. (patchset #1 id:1 of https://codereview.chromium.org/2112223002/ )
    
    Reason for revert:
    Correcting issue.
    
    Original issue's description:
    > Revert of Add errors for declarations which conflict with catch parameters. (patchset #6 id:100001 of https://codereview.chromium.org/2109733003/ )
    >
    > Reason for revert:
    > Fuzzer claims `try {  \"\" ; } catch(x) { let x1 = [1,,], x = x; }` causes a crash.
    >
    > Original issue's description:
    > > Add errors for declarations which conflict with catch parameters.
    > >
    > > Catch parameters are largely treated as lexical declarations in the
    > > block which contains their body for the purposes of early syntax errors,
    > > with some exceptions outlined in B.3.5. This patch introduces most of
    > > those errors, except those from `eval('for (var e of ...);')` inside of
    > > a catch with a simple parameter named 'e'.
    > >
    > > Note that annex B.3.5 allows var declarations to conflict with simple
    > > catch parameters, except when the variable declaration is the init of a
    > > for-of statement.
    > >
    > > BUG=v8:5112,v8:4231
    > >
    > > Committed: https://crrev.com/2907c726b2bb5cf20b2bec639ca9e6a521585406
    > > Cr-Commit-Position: refs/heads/master@{#37462}
    >
    > TBR=littledan@chromium.org
    > # Skipping CQ checks because original CL landed less than 1 days ago.
    > NOPRESUBMIT=true
    > NOTREECHECKS=true
    > NOTRY=true
    > BUG=v8:5112,v8:4231
    >
    > Committed: https://crrev.com/8834d5ecb559001c87c42322969471da60574a8c
    > Cr-Commit-Position: refs/heads/master@{#37464}
    
    R=littledan@chromium.org
    BUG=v8:5112,v8:4231
    
    Review-Url: https://codereview.chromium.org/2119933002
    Cr-Commit-Position: refs/heads/master@{#37728}
    819fe046
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...