• Clemens Backes's avatar
    [wasm][debug] Do not hold lock while recompiling functions · 813c5954
    Clemens Backes authored
    This is to avoid a lock inversion problem. In many situation, the
    {NativeModule} lock is held while getting the {DebugInfo} lock.
    Hence we should never do is the other way around, otherwise we risk a
    deadlock.
    When setting a breakpoint, we hold the {DebugInfo} lock when triggering
    recompilation, but recompilation accesses the {NativeModule} for
    creating the {CompilationEnv}, and therefore takes the {NativeModule}
    lock.
    This CL fixes this lock inversion by giving up the {DebugInfo} lock
    before recompiling functions.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10351
    Change-Id: Ic818c6589b2b532006aee4c16bac92b2fe79fa65
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139574
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67042}
    813c5954
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...