• Leszek Swirski's avatar
    [csa] Fix MSVC handling of VA_ARGS in CSA_ASSERT · 80f6c19f
    Leszek Swirski authored
    MSVC's macro VA_ARGS support behaves slightly differently from
    gcc/clang, where VA_ARGS is treated as a single token when passed to
    other macros, e.g.
    
        #define FIRST(X, ...) 'X'
        #define FOO(...) FIRST(__VA_ARGS__)
        FOO(a,b,c)
    
    expands to
    
        gcc/clang: 'a'
        MSVC: 'a,b,c'
    
    The workaround to this is to wrap the call in a no-op macro, which
    expands VA_ARGS first, and only then passes it through:
    
        #define EXPAND(x) x
        #define FOO(...) EXPAND(FIRST(__VA_ARGS__))
    
    This was causing errors on windows builds when CSA_ASSERT was passed
    multiple additional expressions.
    
    Change-Id: Ia40bf23baf97af29c7f6f67c8a83918ecca15364
    Reviewed-on: https://chromium-review.googlesource.com/586831Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#46927}
    80f6c19f
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...