• Bill Budge's avatar
    Revert "[turbofan][csa] optimize Smi untagging better" · cdea7999
    Bill Budge authored
    This reverts commit ff22ae80.
    
    Reason for revert: new test fails on UBSAN
    https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/10831
    
    Original change's description:
    > [turbofan][csa] optimize Smi untagging better
    > 
    > - Introduce new operator variants for signed right-shifts with the
    >   additional information that they always shift out zeros.
    > - Use these new operators for Smi untagging.
    > - Merge left-shifts with a preceding Smi-untagging shift.
    > - Optimize comparisons of Smi-untagging shifts to operate on the
    >   unshifted word.
    > - Optimize 64bit comparisons of values expanded from 32bit to use
    >   a 32bit comparison instead.
    > - Change CodeStubAssembler::UntagSmi to first sign-extend and then
    >   right-shift to enable better address computations for Smi indices.
    > 
    > Bug: v8:9962
    > Change-Id: If91300f365e8f01457aebf0bd43bdf88b305c460
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135734
    > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67378}
    
    TBR=neis@chromium.org,tebbi@chromium.org
    
    Change-Id: I2617d7a44e5ae33fd79322d37c8b722c00162d22
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:9962
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2165873Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Commit-Queue: Bill Budge <bbudge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67380}
    cdea7999
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
backend Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
regalloc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
branch-elimination-unittest.cc Loading commit data...
bytecode-analysis-unittest.cc Loading commit data...
checkpoint-elimination-unittest.cc Loading commit data...
common-operator-reducer-unittest.cc Loading commit data...
common-operator-unittest.cc Loading commit data...
compiler-test-utils.h Loading commit data...
constant-folding-reducer-unittest.cc Loading commit data...
control-equivalence-unittest.cc Loading commit data...
control-flow-optimizer-unittest.cc Loading commit data...
dead-code-elimination-unittest.cc Loading commit data...
decompression-optimizer-unittest.cc Loading commit data...
diamond-unittest.cc Loading commit data...
effect-control-linearizer-unittest.cc Loading commit data...
graph-reducer-unittest.cc Loading commit data...
graph-reducer-unittest.h Loading commit data...
graph-trimmer-unittest.cc Loading commit data...
graph-unittest.cc Loading commit data...
graph-unittest.h Loading commit data...
int64-lowering-unittest.cc Loading commit data...
js-call-reducer-unittest.cc Loading commit data...
js-create-lowering-unittest.cc Loading commit data...
js-intrinsic-lowering-unittest.cc Loading commit data...
js-native-context-specialization-unittest.cc Loading commit data...
js-operator-unittest.cc Loading commit data...
js-typed-lowering-unittest.cc Loading commit data...
linkage-tail-call-unittest.cc Loading commit data...
load-elimination-unittest.cc Loading commit data...
loop-peeling-unittest.cc Loading commit data...
machine-operator-reducer-unittest.cc Loading commit data...
machine-operator-unittest.cc Loading commit data...
node-cache-unittest.cc Loading commit data...
node-matchers-unittest.cc Loading commit data...
node-properties-unittest.cc Loading commit data...
node-test-utils.cc Loading commit data...
node-test-utils.h Loading commit data...
node-unittest.cc Loading commit data...
opcodes-unittest.cc Loading commit data...
persistent-unittest.cc Loading commit data...
redundancy-elimination-unittest.cc Loading commit data...
schedule-unittest.cc Loading commit data...
scheduler-rpo-unittest.cc Loading commit data...
scheduler-unittest.cc Loading commit data...
simplified-lowering-unittest.cc Loading commit data...
simplified-operator-reducer-unittest.cc Loading commit data...
simplified-operator-unittest.cc Loading commit data...
state-values-utils-unittest.cc Loading commit data...
typed-optimization-unittest.cc Loading commit data...
typer-unittest.cc Loading commit data...
value-numbering-reducer-unittest.cc Loading commit data...
zone-stats-unittest.cc Loading commit data...