• Mythri A's avatar
    [ic] Use the existing prototype validity cell when recomputing handlers · 800c294c
    Mythri A authored
    For keyed stores we recompute handlers based on the receiver maps
    we have seen. This is done so that we can transition to the most generic
    elements kind we have seen so far. When we recompute this handlers we
    get a new prototype validity cell and ignore the existing cell. This
    leads to incorrect behaviour if the cell was invalid. Recomputing the
    handler may be extra work which is not worth doing at this point. So
    we just reuse the existing validity cell and let the IC recompute the
    handler if we see the map again.
    
    Bug: chromium:1053939
    Change-Id: Ifc891d70f5a4b8b774238e12fb40e29b4d174e37
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2122032
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66963}
    800c294c
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...