• Toon Verwaest's avatar
    [parser] Push variables of non-arrow parenthesized expression to parent · 7ff82992
    Toon Verwaest authored
    Parenthesized variable names are valid references for assignment. To make sure
    we can properly mark the variable as assigned, we should push parenthesized
    variables to the outer expression scope after the parenthesized expression is
    guaranteed to not be an arrow head; so that the variable list of the parent is
    complete.
    
    Technically we could probably get by with simply pushing a single variable,
    since more complex expressions aren't valid parenthesized assignment targets:
    (a) = ... and [(a),(b)] = ... are valid, but ([a,b]) = ... isn't.
    It doesn't really seem worth it though.
    
    Bug: chromium:1015372
    Change-Id: I095c35126742a14d0171537b9795f7258c33ab4d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872389
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64455}
    7ff82992
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...