• Toon Verwaest's avatar
    [parser] Push variables of non-arrow parenthesized expression to parent · 7ff82992
    Toon Verwaest authored
    Parenthesized variable names are valid references for assignment. To make sure
    we can properly mark the variable as assigned, we should push parenthesized
    variables to the outer expression scope after the parenthesized expression is
    guaranteed to not be an arrow head; so that the variable list of the parent is
    complete.
    
    Technically we could probably get by with simply pushing a single variable,
    since more complex expressions aren't valid parenthesized assignment targets:
    (a) = ... and [(a),(b)] = ... are valid, but ([a,b]) = ... isn't.
    It doesn't really seem worth it though.
    
    Bug: chromium:1015372
    Change-Id: I095c35126742a14d0171537b9795f7258c33ab4d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872389
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64455}
    7ff82992
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...