• Leszek Swirski's avatar
    [ignition] Fix iteration finalization exception suppression · 7fbbce5f
    Leszek Swirski authored
    The IteratorClose spec specifies that exceptions in
    %GetMethod(iterator.return) are not suppressed by exceptions in the
    given continuation (body of a loop, assignments in destructuring),
    while exceptions in the execution of iterator.return() are.
    
    This means that we have to split out the property access + a typeof
    check to be outside the try-catch, and keep the call inside of it.
    
    The non-split version is only for cases when there is no 'throws'
    continuation (as is the case for yield* calling IteratorClose), so
    the existing BuildIteratorClose can be renamed to reflect this.
    
    Change-Id: Id71aea4fddd6ffb986bd9aaa09d29615a8800f71
    Reviewed-on: https://chromium-review.googlesource.com/c/1402789Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58694}
    7fbbce5f
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...