• Thibaud Michaud's avatar
    [regalloc] Fix slow edge case in BuildBundles · c46c1957
    Thibaud Michaud authored
    The issue is with this pattern, assuming disjoint uses for all vregs:
    
    phi: v1 = v0 ...
    phi: v2 = v0 ...
    phi: v3 = v0 ...
    ...
    phi: vN = v0 ...
    
    For every phi, BuildBundles proceeds as follows:
    - Create a new bundle for the output
    - Merge the input bundle into the output bundle
    
    Since the bundle gets bigger at every iteration, the merges become more
    and more expensive and consume Zone memory that is immediately thrown
    away at the next iteration.
    
    A simple fix is to check the size of the bundles before merging and
    always copy the smallest one into the biggest. In the pattern above this
    should always copy the single-range output bundle into the large input
    bundle.
    
    R=sigurds@chromium.org
    
    Bug: v8:11237
    Change-Id: I6ad9152035da698d94b02b5b41802545ba149307
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584879Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71714}
    c46c1957
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...